Fix securityadmin.sh when copy_custom_security_configs is False #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodolfo Camara Villordo <[email protected]>
peterzhuamazon
approved these changes
Oct 4, 2022
|
Need to backport to 1.x branch with no changes. |
Signed-off-by: Peter Zhu <[email protected]>
prudhvigodithi
approved these changes
Oct 5, 2022
peterzhuamazon
added a commit
to peterzhuamazon/ansible-playbook
that referenced
this pull request
Oct 5, 2022
…search-project#85) * Fix securityadmin.sh when copy_custom_security_configs is False Signed-off-by: Rodolfo Camara Villordo <[email protected]> * Update descriptions Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Rodolfo Camara Villordo <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
peterzhuamazon
added a commit
that referenced
this pull request
Oct 7, 2022
…#99) * Fix securityadmin.sh when copy_custom_security_configs is False Signed-off-by: Rodolfo Camara Villordo <[email protected]> * Update descriptions Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Rodolfo Camara Villordo <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Signed-off-by: Rodolfo Camara Villordo <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Rodolfo Câmara Villordo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rodolfo Camara Villordo [email protected]
Description
Chenge condition to execute the securityadmin.sh script with the parameter
-cdonly when copy_custom_security_configs is true. Also add a task to execute securityadmin.sh with parameter-fwhen copy_custom_security_configs is set to false.Issues Resolved
fix #83
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.