Fix number of total shards in partial search response #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugmakerrrrrr
requested review from
Bukhtawar,
bharath-techie,
Arpit-Bandejiya and
pranikum
as code owners
bharath-techie
approved these changes
Mar 18, 2024
|
@bharath-techie can we merge this |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
=======================================
Coverage ? 84.06%
Complexity ? 559
=======================================
Files ? 61
Lines ? 2046
Branches ? 146
=======================================
Hits ? 1720
Misses ? 230
Partials ? 96 ☔ View full report in Codecov by Sentry. |
bugmakerrrrrr
requested review from
RS146BIJAY,
mch2,
andrross,
Poojita-Raj,
kotwanikunal and
Rishikesh1159
as code owners
Signed-off-by: panguixin <[email protected]> Signed-off-by: Marc Handalian <[email protected]>
|
rebased this - including in 2.14 - thanks @bugmakerrrrrr |
mch2
approved these changes
Apr 30, 2024
kotwanikunal
approved these changes
Apr 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
Signed-off-by: panguixin <[email protected]> Signed-off-by: Marc Handalian <[email protected]> (cherry picked from commit 0402b6d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 0402b6d) Signed-off-by: panguixin <[email protected]> Signed-off-by: Marc Handalian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
totalShardsinSearchResponseincludes skipped shards, but the partial search response inAsynchronousSearchProgressListenerdoes not account for this.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.