Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix andrross and RS146BIJAY aliases #551

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

anasalkouz
Copy link
Member

Description

Fixing errors in the CODEOWNERS files

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bbarani
Copy link
Member

bbarani commented Mar 25, 2024

All the users listed on this CODEOWNERS file have been added as maintainers of this repo.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@eee3ee9). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #551   +/-   ##
=======================================
  Coverage        ?   84.01%           
  Complexity      ?      557           
=======================================
  Files           ?       61           
  Lines           ?     2046           
  Branches        ?      146           
=======================================
  Hits            ?     1719           
  Misses          ?      230           
  Partials        ?       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 added the backport 2.x backport to 2.x label Mar 26, 2024
@mch2 mch2 merged commit e1a249e into opensearch-project:main Mar 26, 2024
13 of 14 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/asynchronous-search/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/asynchronous-search/backport-2.x
# Create a new branch
git switch --create backport/backport-551-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e1a249ef9b8d1805437c2cbc1c8ee1ab245e38c3
# Push it to GitHub
git push --set-upstream origin backport/backport-551-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/asynchronous-search/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-551-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants