-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test for single Node and consume numNodes #1091
Fix test for single Node and consume numNodes #1091
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1091 +/- ##
============================================
- Coverage 75.25% 74.85% -0.40%
+ Complexity 1026 1022 -4
============================================
Files 141 141
Lines 4761 4761
Branches 521 521
============================================
- Hits 3583 3564 -19
- Misses 846 862 +16
- Partials 332 335 +3 |
src/test/kotlin/org/opensearch/replication/integ/rest/StartReplicationIT.kt
Outdated
Show resolved
Hide resolved
65279cd
to
a4a1ff5
Compare
src/test/kotlin/org/opensearch/replication/integ/rest/StartReplicationIT.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/org/opensearch/replication/integ/rest/StartReplicationIT.kt
Outdated
Show resolved
Hide resolved
37e9599
to
1fc05e3
Compare
Signed-off-by: monusingh-1 <[email protected]>
1fc05e3
to
a34afea
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1091-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 81b37ba67efedbbebc804214e7384620006bc4da
# Push it to GitHub
git push --set-upstream origin backport/backport-1091-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
Description
Skip test when single node clusters are used.
wait_for_active_shards setting will not allow the index to close as more than 1 shard will not be active.
This causes the test to fail.
numNodes parameter was not getting consumed by the integTestRemote gradle task.
numNodes param is used to set
isMultiNodeClusterConfiguration
which is used to skip tests like reroute.This change allows numNodes param to be used.
Modified checks to skip Remote integration tests
Assume.assumeTrue(checkifIntegTestRemote())
Ref
#1078
#1085
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.