Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] for CircuitBreaker and Lifecycle #1096

Conversation

monusingh-1
Copy link
Collaborator

Description

Refactor for upstream changes

Recyclers to common library opensearch-project/OpenSearch#9028
Circuit breaker opensearch-project/OpenSearch#9006

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #1096 (1c53734) into main (bcf1144) will decrease coverage by 0.24%.
The diff coverage is n/a.

❗ Current head 1c53734 differs from pull request most recent head e7b1d1d. Consider uploading reports for the commit e7b1d1d to get more accurate results

@@             Coverage Diff              @@
##               main    #1096      +/-   ##
============================================
- Coverage     74.85%   74.62%   -0.24%     
+ Complexity     1025     1018       -7     
============================================
  Files           141      141              
  Lines          4761     4761              
  Branches        521      521              
============================================
- Hits           3564     3553      -11     
- Misses          862      871       +9     
- Partials        335      337       +2     
Files Changed Coverage Δ
...ndex/translog/ReplicationTranslogDeletionPolicy.kt 90.16% <ø> (ø)
...in/org/opensearch/replication/ReplicationPlugin.kt 90.60% <ø> (ø)
.../org/opensearch/replication/ReplicationSettings.kt 100.00% <ø> (ø)
...ication/metadata/store/ReplicationMetadataStore.kt 69.85% <ø> (ø)
...tion/repository/RemoteClusterMultiChunkTransfer.kt 90.24% <ø> (ø)
.../replication/repository/RemoteClusterRepository.kt 73.33% <ø> (ø)
...on/repository/RemoteClusterRestoreLeaderService.kt 78.37% <ø> (ø)
...opensearch/replication/seqno/RemoteClusterStats.kt 100.00% <ø> (ø)
.../replication/seqno/RemoteClusterTranslogService.kt 90.47% <ø> (ø)
...rch/replication/task/index/IndexReplicationTask.kt 68.08% <ø> (+0.21%) ⬆️
... and 1 more

... and 3 files with indirect coverage changes

@monusingh-1 monusingh-1 merged commit 0e6ad7a into opensearch-project:main Aug 2, 2023
11 of 12 checks passed
@monusingh-1 monusingh-1 deleted the refactor_CircuitBreaker_lifecycle branch August 2, 2023 06:40
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2023
Refactor for CircuitBreaker and Lifecycle (#1096)
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 0e6ad7a)
monusingh-1 added a commit that referenced this pull request Aug 7, 2023
Refactor for CircuitBreaker and Lifecycle (#1096)
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 0e6ad7a)
Signed-off-by: monusingh-1 <[email protected]>
monusingh-1 added a commit that referenced this pull request Aug 7, 2023
* Refactor for CircuitBreaker and Lifecycle (#1096)

Refactor for CircuitBreaker and Lifecycle (#1096)
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 0e6ad7a)

* Refactor to core.common.Strings and MediaType

Signed-off-by: monusingh-1 <[email protected]>

---------

Signed-off-by: monusingh-1 <[email protected]>
Co-authored-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants