Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add setting to use document replication for system indices. (… #1107

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Aug 22, 2023

#802)"

This reverts commit 55b6968.

Reverting #802 to remove document replication enforcement.

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1107 (5cf7662) into main (81b37ba) will increase coverage by 0.45%.
The diff coverage is n/a.

❗ Current head 5cf7662 differs from pull request most recent head 969c141. Consider uploading reports for the commit 969c141 to get more accurate results

@@             Coverage Diff              @@
##               main    #1107      +/-   ##
============================================
+ Coverage     74.41%   74.87%   +0.45%     
- Complexity     1019     1026       +7     
============================================
  Files           141      141              
  Lines          4761     4760       -1     
  Branches        521      521              
============================================
+ Hits           3543     3564      +21     
+ Misses          879      863      -16     
+ Partials        339      333       -6     
Files Changed Coverage Δ
...ication/metadata/store/ReplicationMetadataStore.kt 69.62% <ø> (-0.23%) ⬇️

... and 7 files with indirect coverage changes

@monusingh-1 monusingh-1 force-pushed the revert_doc_replication_enforcement branch from 4737934 to 969c141 Compare August 22, 2023 11:25
@monusingh-1 monusingh-1 marked this pull request as ready for review August 22, 2023 11:25
@monusingh-1 monusingh-1 enabled auto-merge (squash) August 22, 2023 13:21
@monusingh-1 monusingh-1 merged commit 9750b78 into opensearch-project:main Aug 22, 2023
10 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 22, 2023
…802)" (#1107)

This reverts commit 55b6968.

Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 9750b78)
monusingh-1 added a commit that referenced this pull request Aug 22, 2023
…802)" (#1107) (#1108)

This reverts commit 55b6968.

Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 9750b78)

Co-authored-by: Monu Singh <[email protected]>
@monusingh-1 monusingh-1 deleted the revert_doc_replication_enforcement branch November 2, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants