Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix checkpoint and enable test #1110

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Aug 28, 2023

Description

Add statement which was responsible for updating follower checkpoint.

Enable test for follower check point.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1110 (529ecfe) into 2.7 (d97859a) will increase coverage by 2.16%.
The diff coverage is 100.00%.

❗ Current head 529ecfe differs from pull request most recent head 729f787. Consider uploading reports for the commit 729f787 to get more accurate results

@@             Coverage Diff              @@
##                2.7    #1110      +/-   ##
============================================
+ Coverage     72.95%   75.11%   +2.16%     
- Complexity     1022     1037      +15     
============================================
  Files           141      141              
  Lines          4769     4770       +1     
  Branches        534      534              
============================================
+ Hits           3479     3583     +104     
+ Misses          961      854     -107     
- Partials        329      333       +4     
Files Changed Coverage Δ
...search/replication/task/shard/TranslogSequencer.kt 73.84% <100.00%> (+0.40%) ⬆️

... and 11 files with indirect coverage changes

@monusingh-1 monusingh-1 marked this pull request as ready for review August 28, 2023 08:55
@monusingh-1 monusingh-1 changed the title fix checkpoint [Bug] fix checkpoint and enable tests Aug 28, 2023
@monusingh-1 monusingh-1 changed the title [Bug] fix checkpoint and enable tests [Bug] fix checkpoint and enable test Aug 28, 2023
@monusingh-1 monusingh-1 merged commit 61fd7ad into opensearch-project:2.7 Aug 28, 2023
10 of 12 checks passed
@monusingh-1 monusingh-1 deleted the fix_2.7_checkpoint branch November 2, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants