-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement abstract methods of Repository #1111
Merged
monusingh-1
merged 2 commits into
opensearch-project:main
from
monusingh-1:implement_remoteclusterrepo
Sep 1, 2023
Merged
Implement abstract methods of Repository #1111
monusingh-1
merged 2 commits into
opensearch-project:main
from
monusingh-1:implement_remoteclusterrepo
Sep 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
monusingh-1
changed the title
Implement remoteclusterrepo
Implement abstract methods of Repository
Sep 1, 2023
Codecov Report
@@ Coverage Diff @@
## main #1111 +/- ##
============================================
+ Coverage 74.85% 75.07% +0.22%
Complexity 1022 1022
============================================
Files 141 141
Lines 4760 4762 +2
Branches 521 521
============================================
+ Hits 3563 3575 +12
+ Misses 861 854 -7
+ Partials 336 333 -3
|
monusingh-1
requested review from
krishna-ggk,
ankitkala,
saikaranam-amazon,
soosinha and
gbbafna
as code owners
September 1, 2023 09:15
ankitkala
approved these changes
Sep 1, 2023
soosinha
approved these changes
Sep 1, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Implement methods Signed-off-by: monusingh-1 <[email protected]> * Implement methods Signed-off-by: monusingh-1 <[email protected]> --------- Signed-off-by: monusingh-1 <[email protected]> (cherry picked from commit b6d1b56)
monusingh-1
added a commit
that referenced
this pull request
Sep 1, 2023
* Implement methods Signed-off-by: monusingh-1 <[email protected]> * Implement methods Signed-off-by: monusingh-1 <[email protected]> --------- Signed-off-by: monusingh-1 <[email protected]> (cherry picked from commit b6d1b56) Co-authored-by: Monu Singh <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current builds failing
Implemented abstract methods
getRemoteUploadThrottleTimeInNanos
getRemoteDownloadThrottleTimeInNanos
caused by opensearch-project/OpenSearch@334b15a#diff-15dd2c1859d8b3091b1b702af9c5bbdd680224671444870daf9f392d4e838fa1R201
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.