Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abstract methods of Repository #1111

Merged

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Sep 1, 2023

Description

Current builds failing

e: file:///Users/user/main/ccr-dev/src/main/kotlin/org/opensearch/replication/repository/RemoteClusterRepository.kt:82:1 Class 'RemoteClusterRepository' is not abstract and does not implement abstract member public abstract fun getRemoteUploadThrottleTimeInNanos(): Long defined in org.opensearch.repositories.Repository

Implemented abstract methods
getRemoteUploadThrottleTimeInNanos
getRemoteDownloadThrottleTimeInNanos

caused by opensearch-project/OpenSearch@334b15a#diff-15dd2c1859d8b3091b1b702af9c5bbdd680224671444870daf9f392d4e838fa1R201

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
@monusingh-1 monusingh-1 changed the title Implement remoteclusterrepo Implement abstract methods of Repository Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #1111 (574f91f) into main (9750b78) will increase coverage by 0.22%.
The diff coverage is 0.00%.

❗ Current head 574f91f differs from pull request most recent head 5d8b093. Consider uploading reports for the commit 5d8b093 to get more accurate results

@@             Coverage Diff              @@
##               main    #1111      +/-   ##
============================================
+ Coverage     74.85%   75.07%   +0.22%     
  Complexity     1022     1022              
============================================
  Files           141      141              
  Lines          4760     4762       +2     
  Branches        521      521              
============================================
+ Hits           3563     3575      +12     
+ Misses          861      854       -7     
+ Partials        336      333       -3     
Files Changed Coverage Δ
.../replication/repository/RemoteClusterRepository.kt 72.26% <0.00%> (-1.08%) ⬇️

... and 8 files with indirect coverage changes

@monusingh-1 monusingh-1 merged commit b6d1b56 into opensearch-project:main Sep 1, 2023
11 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 1, 2023
* Implement methods

Signed-off-by: monusingh-1 <[email protected]>

* Implement methods

Signed-off-by: monusingh-1 <[email protected]>

---------

Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit b6d1b56)
@monusingh-1 monusingh-1 deleted the implement_remoteclusterrepo branch September 1, 2023 12:57
monusingh-1 added a commit that referenced this pull request Sep 1, 2023
* Implement methods

Signed-off-by: monusingh-1 <[email protected]>

* Implement methods

Signed-off-by: monusingh-1 <[email protected]>

---------

Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit b6d1b56)

Co-authored-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants