Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abstract methods #1121

Conversation

monusingh-1
Copy link
Collaborator

@monusingh-1 monusingh-1 commented Sep 7, 2023

Description

upstream change opensearch-project/OpenSearch#9105

Implemented

isSystemRepository
getRemoteDownloadThrottleTimeInNanos
getRemoteUploadThrottleTimeInNanos

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: monusingh-1 <[email protected]>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #1121 (2ee1391) into main (9750b78) will increase coverage by 0.36%.
Report is 4 commits behind head on main.
The diff coverage is 25.00%.

❗ Current head 2ee1391 differs from pull request most recent head 9ef2f4a. Consider uploading reports for the commit 9ef2f4a to get more accurate results

@@             Coverage Diff              @@
##               main    #1121      +/-   ##
============================================
+ Coverage     74.85%   75.22%   +0.36%     
- Complexity     1022     1028       +6     
============================================
  Files           141      141              
  Lines          4760     4762       +2     
  Branches        521      521              
============================================
+ Hits           3563     3582      +19     
+ Misses          861      851      -10     
+ Partials        336      329       -7     
Files Changed Coverage Δ
.../replication/repository/RemoteClusterRepository.kt 71.73% <0.00%> (-1.60%) ⬇️
...tlin/org/opensearch/replication/util/Extensions.kt 63.33% <100.00%> (-0.41%) ⬇️

... and 8 files with indirect coverage changes

@mohitamg mohitamg mentioned this pull request Sep 7, 2023
23 tasks
@monusingh-1 monusingh-1 enabled auto-merge (squash) September 7, 2023 12:27
@monusingh-1 monusingh-1 merged commit 0fbe5a7 into opensearch-project:main Sep 7, 2023
11 of 12 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2023
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 0fbe5a7)
@monusingh-1 monusingh-1 deleted the implement_remoteclusterrepo2 branch September 7, 2023 12:37
monusingh-1 added a commit that referenced this pull request Sep 7, 2023
Signed-off-by: monusingh-1 <[email protected]>
(cherry picked from commit 0fbe5a7)

Co-authored-by: Monu Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants