-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to run build on Container image used by release pipeline #1249
Add support to run build on Container image used by release pipeline #1249
Conversation
Signed-off-by: monusingh-1 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=============================================
- Coverage 74.75% 46.17% -28.59%
+ Complexity 1024 623 -401
=============================================
Files 141 141
Lines 4762 4762
Branches 521 521
=============================================
- Hits 3560 2199 -1361
- Misses 868 2301 +1433
+ Partials 334 262 -72 |
Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
Hi @ankitkala @monusingh-1 I am adding some changes directly to this PR. Will commit soon. Thanks |
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Ready for review. Thanks! |
.github/workflows/build.yml
Outdated
|
||
name: Build and Test CCR Plugin on Linux | ||
runs-on: ubuntu-latest | ||
needs: Get-CI-Image-Tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we're adding any value by this extra workflow Build on ubuntu with ci image
. We're already testing the same under build-and-test
. This one can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
Signed-off-by: monusingh-1 <[email protected]>
Signed-off-by: monusingh-1 <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1249-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0bd703bf1468c088b760e274024477df52ac35a1
# Push it to GitHub
git push --set-upstream origin backport/backport-1249-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Hi @ankitkala @monusingh-1 thanks for merging. Thanks! |
Signed-off-by: monusingh-1 <[email protected]>
Description
CI to run on top of the Build Docker Images from production distribution pipeline.
Issues Resolved
#1228
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.