Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CCR compatibility with remote translogs #1271

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

ankitkala
Copy link
Member

@ankitkala ankitkala commented Oct 18, 2023

Description

Fix CCR compatibility with remote translogs
Changes done:

  • Route GetChangesRequest only to leader's primary shard.
  • Rely on lucene as source for operations.
  • Disabled the TranslogDeletionPolicy for remote enabled clusters.
  • Excluded Remote store settings while copying leader index's setting to follower index.

Testing done:

  • Manual testing with remote store enabled.
  • Enabled remote store on leader and ran the integ test suite. Verified that all tests passed(one test failed with leader stats due to assertion on lucene reads which is expected)

We can explore having a CI for testing with remote clusters. Will open a follow up issue for same.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #1271 (5fec1ee) into main (0bd703b) will decrease coverage by 0.10%.
The diff coverage is 43.47%.

❗ Current head 5fec1ee differs from pull request most recent head b5302a0. Consider uploading reports for the commit b5302a0 to get more accurate results

@@             Coverage Diff              @@
##               main    #1271      +/-   ##
============================================
- Coverage     46.17%   46.08%   -0.10%     
- Complexity      623      625       +2     
============================================
  Files           141      141              
  Lines          4762     4776      +14     
  Branches        521      525       +4     
============================================
+ Hits           2199     2201       +2     
- Misses         2301     2304       +3     
- Partials        262      271       +9     
Files Coverage Δ
.../replication/repository/RemoteClusterRepository.kt 70.92% <100.00%> (+0.63%) ⬆️
.../org/opensearch/replication/util/ValidationUtil.kt 23.63% <0.00%> (-0.44%) ⬇️
...in/org/opensearch/replication/ReplicationPlugin.kt 87.58% <50.00%> (-1.69%) ⬇️
...cation/action/changes/TransportGetChangesAction.kt 56.52% <30.76%> (-8.56%) ⬇️

@ankitkala
Copy link
Member Author

Backlog issue to create a CI workflow for CCR with remote store: #1272

@ankitkala ankitkala merged commit e1d2596 into opensearch-project:main Oct 18, 2023
14 of 16 checks passed
@nisgoel-amazon
Copy link
Contributor

We need to backport it to 2.11 and 2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants