-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CCR compatibility with remote translogs #1271
Merged
ankitkala
merged 1 commit into
opensearch-project:main
from
ankitkala:ccr_remote_translog
Oct 18, 2023
Merged
Fix CCR compatibility with remote translogs #1271
ankitkala
merged 1 commit into
opensearch-project:main
from
ankitkala:ccr_remote_translog
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkala
requested review from
krishna-ggk,
saikaranam-amazon,
soosinha,
gbbafna and
monusingh-1
as code owners
October 18, 2023 04:32
Signed-off-by: Ankit Kala <[email protected]>
ankitkala
force-pushed
the
ccr_remote_translog
branch
from
October 18, 2023 04:38
f60582f
to
b5302a0
Compare
Codecov Report
@@ Coverage Diff @@
## main #1271 +/- ##
============================================
- Coverage 46.17% 46.08% -0.10%
- Complexity 623 625 +2
============================================
Files 141 141
Lines 4762 4776 +14
Branches 521 525 +4
============================================
+ Hits 2199 2201 +2
- Misses 2301 2304 +3
- Partials 262 271 +9
|
Backlog issue to create a CI workflow for CCR with remote store: #1272 |
gbbafna
approved these changes
Oct 18, 2023
src/main/kotlin/org/opensearch/replication/action/changes/TransportGetChangesAction.kt
Show resolved
Hide resolved
saikaranam-amazon
approved these changes
Oct 18, 2023
monusingh-1
reviewed
Oct 18, 2023
monusingh-1
approved these changes
Oct 18, 2023
We need to backport it to 2.11 and 2.10 |
This was referenced Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix CCR compatibility with remote translogs
Changes done:
Testing done:
We can explore having a CI for testing with remote clusters. Will open a follow up issue for same.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.