-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to fetch changes from Lucene store while migrating from/to r… #1369
Adding support to fetch changes from Lucene store while migrating from/to r… #1369
Conversation
…emote store Signed-off-by: Shubh Sahu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
src/main/kotlin/org/opensearch/replication/action/changes/TransportGetChangesAction.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/replication/util/ValidationUtil.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Shubh Sahu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall changes looks good to me!
Have few minor comments.
src/test/kotlin/org/opensearch/replication/integ/rest/StartReplicationIT.kt
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/replication/util/ValidationUtil.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/opensearch/replication/action/changes/TransportGetChangesAction.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Shubh Sahu <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1369-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ff42012067e0b14e0e15b79c9be542cbdff08031
# Push it to GitHub
git push --set-upstream origin backport/backport-1369-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…m/to r… (opensearch-project#1369) Signed-off-by: Shubh Sahu <[email protected]>
…m/to r… (#1369) (#1375) Signed-off-by: Shubh Sahu <[email protected]>
…m/to r… (opensearch-project#1369) (opensearch-project#1375) Signed-off-by: Shubh Sahu <[email protected]>
…emote store to/from Docrep.
Description
In today's scenario, follower index fetch changes from leader index through translog if the leader cluster is DocRep based and through lucene store if the leader cluster is RemoteStore based. In case of
mixed
mode, when cluster is migrating from DocRep to RemoteStore or vice versa , we want to fetch the changes from lucene store only.Issues Resolved
Resolves #1360
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.