Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to fetch changes from Lucene store while migrating from/to r… #1369

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

astute-decipher
Copy link
Contributor

…emote store to/from Docrep.

Description

In today's scenario, follower index fetch changes from leader index through translog if the leader cluster is DocRep based and through lucene store if the leader cluster is RemoteStore based. In case of mixed mode, when cluster is migrating from DocRep to RemoteStore or vice versa , we want to fetch the changes from lucene store only.

Issues Resolved

Resolves #1360

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@gbbafna gbbafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Shubh Sahu <[email protected]>
gbbafna
gbbafna previously approved these changes Apr 19, 2024
Copy link
Member

@ankitkala ankitkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall changes looks good to me!
Have few minor comments.

@gbbafna gbbafna enabled auto-merge (squash) April 22, 2024 12:58
@gbbafna gbbafna merged commit ff42012 into opensearch-project:main Apr 23, 2024
14 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1369-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ff42012067e0b14e0e15b79c9be542cbdff08031
# Push it to GitHub
git push --set-upstream origin backport/backport-1369-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1369-to-2.x.

astute-decipher added a commit to astute-decipher/cross-cluster-replication that referenced this pull request Apr 24, 2024
gbbafna pushed a commit that referenced this pull request Apr 24, 2024
skumarp7 pushed a commit to nokia/opensearch-project-cross-cluster-replication that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote Migration] Support CCR while migrating to/from remote store
3 participants