Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numNodes parameter in security tests #991

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

soosinha
Copy link
Member

@soosinha soosinha commented Jun 7, 2023

Description

Some of the integ tests like those for wait_for_active_shards need atleast 2 nodes in the cluster to run successfully. Removing the numNodes=1 parameter so that by default 2 node cluster is created

Issues Resolved

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #991 (255339e) into main (0fbe5a7) will increase coverage by 0.31%.
The diff coverage is n/a.

❗ Current head 255339e differs from pull request most recent head d959e11. Consider uploading reports for the commit d959e11 to get more accurate results

@@             Coverage Diff              @@
##               main     #991      +/-   ##
============================================
+ Coverage     72.78%   73.09%   +0.31%     
- Complexity     1005     1011       +6     
============================================
  Files           141      141              
  Lines          4762     4762              
  Branches        521      521              
============================================
+ Hits           3466     3481      +15     
+ Misses          948      934      -14     
+ Partials        348      347       -1     

see 6 files with indirect coverage changes

@monusingh-1
Copy link
Collaborator

Do we want to merge this ?

Some of the integ tests like those for wait_for_active_shards need
atleast 2 nodes in the cluster to run successfully. Removing the
numNodes=1 parameter so that by default 2 node cluster is created

Signed-off-by: Sooraj Sinha <[email protected]>
@monusingh-1 monusingh-1 merged commit c19dcba into opensearch-project:main Sep 11, 2023
10 of 11 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-991-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c19dcba791a8a60f660e1367925bd08d01a57b9e
# Push it to GitHub
git push --set-upstream origin backport/backport-991-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-991-to-2.x.

soosinha added a commit to soosinha/cross-cluster-replication that referenced this pull request Sep 11, 2023
Some of the integ tests like those for wait_for_active_shards need
atleast 2 nodes in the cluster to run successfully. Removing the
numNodes=1 parameter so that by default 2 node cluster is created

Signed-off-by: Sooraj Sinha <[email protected]>
(cherry picked from commit c19dcba)
monusingh-1 pushed a commit that referenced this pull request Sep 11, 2023
Some of the integ tests like those for wait_for_active_shards need
atleast 2 nodes in the cluster to run successfully. Removing the
numNodes=1 parameter so that by default 2 node cluster is created

Signed-off-by: Sooraj Sinha <[email protected]>
(cherry picked from commit c19dcba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants