-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove numNodes parameter in security tests #991
Remove numNodes parameter in security tests #991
Conversation
Codecov Report
@@ Coverage Diff @@
## main #991 +/- ##
============================================
+ Coverage 72.78% 73.09% +0.31%
- Complexity 1005 1011 +6
============================================
Files 141 141
Lines 4762 4762
Branches 521 521
============================================
+ Hits 3466 3481 +15
+ Misses 948 934 -14
+ Partials 348 347 -1 |
Do we want to merge this ? |
Some of the integ tests like those for wait_for_active_shards need atleast 2 nodes in the cluster to run successfully. Removing the numNodes=1 parameter so that by default 2 node cluster is created Signed-off-by: Sooraj Sinha <[email protected]>
b6f5e30
to
d959e11
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-991-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c19dcba791a8a60f660e1367925bd08d01a57b9e
# Push it to GitHub
git push --set-upstream origin backport/backport-991-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Some of the integ tests like those for wait_for_active_shards need atleast 2 nodes in the cluster to run successfully. Removing the numNodes=1 parameter so that by default 2 node cluster is created Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit c19dcba)
Some of the integ tests like those for wait_for_active_shards need atleast 2 nodes in the cluster to run successfully. Removing the numNodes=1 parameter so that by default 2 node cluster is created Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit c19dcba)
Description
Some of the integ tests like those for wait_for_active_shards need atleast 2 nodes in the cluster to run successfully. Removing the numNodes=1 parameter so that by default 2 node cluster is created
Issues Resolved
NA
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.