Add consistency in form modal footer btns

Signed-off-by: Tyler Ohlsen <[email protected]>
opensearch-project · Nov 4, 2024 · e225d46 · e225d46
1 parent bdd2db4
commit e225d46
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 32 deletions.
diff --git a/public/pages/workflow_detail/workflow_inputs/ingest_inputs/source_data_modal.tsx b/public/pages/workflow_detail/workflow_inputs/ingest_inputs/source_data_modal.tsx
@@ -22,6 +22,7 @@ import {
   EuiSmallFilterButton,
   EuiSuperSelectOption,
   EuiCompressedSuperSelect,
+  EuiSmallButtonEmpty,
 } from '@elastic/eui';
 import { JsonField } from '../input_fields';
 import {
@@ -297,14 +298,13 @@ export function SourceDataModal(props: SourceDataProps) {
               </>
             </EuiModalBody>
             <EuiModalFooter>
-              <EuiSmallButton
+              <EuiSmallButtonEmpty
                 onClick={() => onClose()}
-                fill={false}
                 color="primary"
                 data-testid="closeSourceDataButton"
               >
                 Cancel
-              </EuiSmallButton>
+              </EuiSmallButtonEmpty>
               <EuiSmallButton
                 onClick={() => onUpdate()}
                 isLoading={isUpdating}
@@ -313,7 +313,7 @@ export function SourceDataModal(props: SourceDataProps) {
                 color="primary"
                 data-testid="updateSourceDataButton"
               >
-                Update
+                Save
               </EuiSmallButton>
             </EuiModalFooter>
           </EuiModal>

diff --git a/...c/pages/workflow_detail/workflow_inputs/processor_inputs/modals/input_transform_modal.tsx b/...c/pages/workflow_detail/workflow_inputs/processor_inputs/modals/input_transform_modal.tsx
@@ -569,9 +569,9 @@ export function InputTransformModal(props: InputTransformModalProps) {
                             }
                             color="warning"
                           />
+                          <EuiSpacer size="s" />
                         </>
                       )}
-                      <EuiSpacer size="s" />
                       {props.context === PROCESSOR_CONTEXT.SEARCH_RESPONSE && (
                         <>
                           {OneToOneConfig}

diff --git a/.../pages/workflow_detail/workflow_inputs/processor_inputs/modals/output_transform_modal.tsx b/.../pages/workflow_detail/workflow_inputs/processor_inputs/modals/output_transform_modal.tsx
@@ -492,29 +492,31 @@ root object selector "${JSONPATH_ROOT_SELECTOR}"`}
                     </EuiFlexItem>
                   </EuiFlexGroup>
                   <EuiFlexItem>
-                    {(onIngestAndNoDocs || onSearchAndNoQuery) && (
-                      <>
-                        <EuiCallOut
-                          size="s"
-                          title={
-                            onIngestAndNoDocs
-                              ? 'No source documents detected. Fetching is unavailable.'
-                              : 'No source query detected. Fetching is unavailable.'
-                          }
-                          color="warning"
-                        />
-                        <EuiSpacer size="s" />
-                        {(props.context === PROCESSOR_CONTEXT.INGEST ||
-                          props.context ===
-                            PROCESSOR_CONTEXT.SEARCH_RESPONSE) && (
-                          <>
-                            {FullResponsePathConfig}
-                            <EuiSpacer size="s" />
-                          </>
-                        )}
-                        {FetchButton}
-                      </>
-                    )}
+                    <>
+                      {(onIngestAndNoDocs || onSearchAndNoQuery) && (
+                        <>
+                          <EuiCallOut
+                            size="s"
+                            title={
+                              onIngestAndNoDocs
+                                ? 'No source documents detected. Fetching is unavailable.'
+                                : 'No source query detected. Fetching is unavailable.'
+                            }
+                            color="warning"
+                          />
+                          <EuiSpacer size="s" />
+                        </>
+                      )}
+                      {(props.context === PROCESSOR_CONTEXT.INGEST ||
+                        props.context ===
+                          PROCESSOR_CONTEXT.SEARCH_RESPONSE) && (
+                        <>
+                          {FullResponsePathConfig}
+                          <EuiSpacer size="s" />
+                        </>
+                      )}
+                      {FetchButton}
+                    </>
                   </EuiFlexItem>
                   <EuiSpacer size="s" />
                   <EuiFlexGroup direction="row">

diff --git a/public/pages/workflow_detail/workflow_inputs/search_inputs/edit_query_modal.tsx b/public/pages/workflow_detail/workflow_inputs/search_inputs/edit_query_modal.tsx
@@ -17,6 +17,7 @@ import {
   EuiModalHeaderTitle,
   EuiPopover,
   EuiSpacer,
+  EuiSmallButtonEmpty,
 } from '@elastic/eui';
 import { JsonField } from '../input_fields';
 import {
@@ -139,14 +140,13 @@ export function EditQueryModal(props: EditQueryModalProps) {
               />
             </EuiModalBody>
             <EuiModalFooter>
-              <EuiSmallButton
+              <EuiSmallButtonEmpty
                 onClick={() => props.setModalOpen(false)}
-                fill={false}
                 color="primary"
                 data-testid="cancelSearchQueryButton"
               >
                 Cancel
-              </EuiSmallButton>
+              </EuiSmallButtonEmpty>
               <EuiSmallButton
                 onClick={() => {
                   setFieldValue(props.queryFieldPath, tempRequest);
@@ -158,7 +158,7 @@ export function EditQueryModal(props: EditQueryModalProps) {
                 color="primary"
                 data-testid="updateSearchQueryButton"
               >
-                Update
+                Save
               </EuiSmallButton>
             </EuiModalFooter>
           </EuiModal>