Omit lint workflow temporarily #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage 19.30% 19.30%
=======================================
Files 50 50
Lines 746 746
Branches 71 73 +2
=======================================
Hits 144 144
Misses 595 595
Partials 7 7 ☔ View full report in Codecov by Sentry. |
owaiskazi19
reviewed
Mar 6, 2024
| # - name: Run lint script | ||
| # run: | | ||
| # cd OpenSearch-Dashboards/plugins/dashboards-flow-framework | ||
| # yarn lint:es common/* public/* server/* |
There was a problem hiding this comment.
Instead of commenting the workflow, you can disable it from Github itself. Ref
There was a problem hiding this comment.
Oh awesome! I've just disabled from there. Closing this PR, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the ongoing development & many TODOs & console log statements included, the lint workflow is always failing, and consequently causes all PRs to never have fully passing CI checks. This PR omits that workflow for now.
Tracking issue to re-enable (currently targeting an ECD of 2.15): #109
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.