-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server-side workflow template library #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
March 13, 2024 01:03
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 25.42% 20.20% -5.23%
==========================================
Files 53 54 +1
Lines 763 797 +34
Branches 73 74 +1
==========================================
- Hits 194 161 -33
- Misses 562 630 +68
+ Partials 7 6 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
changed the title
Add frontend workflow template library
Add server-side workflow template library
Mar 13, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
joshpalis
approved these changes
Mar 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 83835c2)
ohltyler
added a commit
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 83835c2) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the placeholder function to fetch hardcoded preset workflows, and replaces it with a dynamically-fetched set of workflows via JSON templates persisted on the server side under
server/resources/templates
. This allows easy addition and updates to preset workflows; simply adding a valid JSON file will now automatically add to the list of available preset workflows when navigating to theNew workflow
tab. Dynamic fetching is done via server APIs and preset workflows persisting in redux state. Validation is done when parsing the JSON files (logic is stubbed for now).Note we may fetch presets and other OOTB configs from the backend or other central repository in the future. That design is still in progress.
To handle this, a variety of cleanup to interfaces and utils fns were made:
WorkflowTemplate
andWorkflow
interfaces to match more closely with the backendDemo video below shows the
New workflow
tab being populated based on the JSONs saved in server-side, as well as some automatically generated placeholder workflows state nodes/edges.screen-capture.17.webm
Issues Resolved
Resolves #72
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.