-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to select and provision pretrained text embedding models #137
Conversation
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Might have missed it in the code but also if its a pretrained model it has the info like dimensions in the model metadata for further steps that need that |
…137) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 76584f4)
…137) (#138) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 76584f4) Co-authored-by: Tyler Ohlsen <[email protected]>
Right. I have this in line 196 in |
Description
This PR adds the ability to select existing models, or select from available pretrained models, in the text embedding processor component. Specifically:
ModelField
field type to process all of the logic around model selection, including only showing valid deployed models, and available pretrained models. Note: the final props and how customizable this field will need to be is TBD. For example, we can customize it to be tailored towards text embedding models vs. other types of models in the futuretoTemplateNodes
to dynamically handle the template node creation based on a pretrained vs. existing/deployed model. If a pretrained model is selected, we add a previous step to register and deploy that model, and use the produced model ID in the downstreamcreate_ingest_pipeline step
. Else, use the existing logic and just use the user/form-supplied model ID directly in a singlecreate_ingest_pipeline
step.Misc:
Flow Framework
breadcrumbDemo video:
screen-capture.29.webm
Issues Resolved
Makes progress on #73
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.