Remove public/ imports in common/
#147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Apr 23, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Remove public references in common/ Signed-off-by: Tyler Ohlsen <[email protected]> * handle NPE Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 23f222c)
ohltyler
added a commit
that referenced
this pull request
May 8, 2024
------ Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 23f222c) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes all instances of pulling in
public/modules intocommon. This breaks things when trying to run the built plugin (compiled JS) in a distribution build, but doesn't cause errors in a dev environment otherwise. The consequence of moving these, is a bunch of import refactoring was needed across all files. Audited all moved imports to ensure none are missed, also sanity tested plugin flows. Also adds a one-line change to handle an edge-case NPE.Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.