Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable workflow updates and document ingest #166

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Enable workflow updates and document ingest #166

merged 4 commits into from
Jun 6, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jun 6, 2024 •
edited
Loading

Description

This PR enables basic ingestion and viewing the ingestion response in the tools panel. Specifically:

  • adds an ingestResponse var to persist at the global workspace level to be viewed from anywhere
  • implements fns needed for performing validating/deprovision/update/provision of workflows if the user updates something (changes index name, changes/adds ingest processors, etc.). In the future we can leverage the backend fine-grained provisioning work to simplify this to 1 API call instead of 3, and allow for optimized deprovisioning (removing the requirement to deprovision things like indices or models, if a user updates some resource that is unrelated).
  • perform validation/deprovision/update/provision when a user clicks 'Run ingestion'. This a pre-requisite for the configuration to be up-to-date before any sample docs are ingested. This will be used in an identical way on the search side.

Other improvements:

  • makes Tools panel consistent with the other panels, allow scrolling overflow in the tab bodies
  • clean up and simplify the index component to only support 'create new' per the latest UX mockups.

Demo video (updating workflow with a configured ingest pipeline and index name, ingesting the sample document, showing ingest response under the ingest tab in the tools panel):

screen-capture.36.webm

Issues Resolved

Makes progress on #23

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler merged commit 2eb0bb9 into opensearch-project:main Jun 6, 2024
10 checks passed
@ohltyler ohltyler deleted the ingest branch June 6, 2024 22:34
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 6, 2024
@ohltyler @github-actions
Enable workflow updates and document ingest (#166)
f175a7d 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 2eb0bb9)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 6, 2024
Merged
ohltyler added a commit that referenced this pull request Jun 6, 2024
@opensearch-trigger-bot @ohltyler
Enable workflow updates and document ingest (#166) (#167)
ab25005 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 2eb0bb9)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@amitgalitz amitgalitz amitgalitz approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
backport 2.x rapid workflow editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohltyler @amitgalitz @joshpalis