-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard ML inference ingest processor #172
Merged
ohltyler
merged 9 commits into
opensearch-project:main
from
ohltyler:ml-inference-processor
Jun 11, 2024
Merged
Onboard ML inference ingest processor #172
ohltyler
merged 9 commits into
opensearch-project:main
from
ohltyler:ml-inference-processor
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
…late creation Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
June 10, 2024 23:57
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
joshpalis
approved these changes
Jun 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit f077c82)
ohltyler
added a commit
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit f077c82) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR onboards the generic ML inference ingest processor into the plugin. Specifically:
MLInferenceProcessor
interface used when constructing the workflow templateMLTransformer
undercomponents/
(the interfaces for the ReactFlow drag-and-drop components)configs/
(the interfaces/classes used for theWorkflowInputs
form) to support the ML inference processor. Specifies the baseml_processor
config at the top-level, as the form inputs will be identical across the underlying ingest / search request / search response processorsmap
config field type and associated interfaces to represent a map as a list of k/v pairs (note this is the format expected in the ml inference processors)workflow_to_template_utils
and removes the logic around pretrained models and handling model provisioning, as this is not in the target scope of initial release for thisMapField
for processing a dynamic list of k/v pairs to represent a mapping - includes the components,Formik
form integration, andyup
schema validationDemo video, showing the dynamic list of mappings for the input and output maps, persisted in the config, form validation, and actual execution. (Errors on the execution can be ignored for now; this work is in-progress. I have confirmed the ingest pipeline, default pipeline on the index, and execution of the ingest are all working as expected, as the errors faced are replicable by perform ingest directly against the created index.)
screen-capture.39.webm
Issues Resolved
Makes progress on #23
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.