Integrate with JSONPath; complete input transform (ingest) #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
…modal Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
…rocessor implementation Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
approved these changes
Jul 22, 2024
| label="Input map" | ||
| helpText={`An array specifying how to map fields from the ingested document to the model’s input.`} | ||
| helpLink={ | ||
| 'https://opensearch.org/docs/latest/ingest-pipelines/processors/ml-inference/#configuration-parameters' |
There was a problem hiding this comment.
We should have the links in a common file or the constant file
There was a problem hiding this comment.
Good point, will move in the next PR
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit d490d15)
ohltyler
added a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit d490d15) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the end-to-end flow of input transforms on the ingest side, by way of adding JSONPath parsing support within the ML inference input map configs. More specifically:
InputTransformModal- adds the map form field within the modal, completes generation logic of the output JSON after applying JSONPath and/or dot notation to the specified inputs in the map. Note the logic used here is the same as the ML inference processor logic, when parsing the map config. If no$.JSONPath base object selector is specified, it defaults to using dot notation. We do the same logic to produce consistent results when actually used in the ML inference processorInputTransformModalto just beclose, since the autosave will handle itkeyPlaceholder/valuePlaceholderprops toMapFieldto be able to reuse in the output maps and for other contexts (ingest / search req / search resp) later onTesting
Demo video, showing end-to-end flow of configuring an ML inference processor's input_map using both dot notation and JSONPath, getting sample results in the advanced transform modal, and finally running a concrete ingest command against the configured processor:
screen-capture.8.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.