Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up plugin boilerplate & placeholder pages #3
Set up plugin boilerplate & placeholder pages #3
Changes from all commits
4ede5df
524a289
2905746
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do some of these use
use_node
and others don't?Also, plugins should also have a
lint:style
script, that calls../../scripts/use_node ../../scripts/stylelint
(which should be part of the CI workflow, along withlint:es
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll clean up the
use_node
vs.node
differences, I referenced some of this from different existing plugins.Thanks for the suggestions on the lint scripts - I'll work on that + adding a github workflow for them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSFishy I've updated and added a lint script in latest commit. For some reason there is an issue with that commit showing up as part of this PR, checking on if that is a newly-public-repo config that needs updated or related to the list of incidents that've happened today