Prefill dimension if known remote model found; onboard search connectors API #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
added
backport 2.x
rapid
new workflow
Roadmap:Ease of Use
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
approved these changes
Aug 30, 2024
|
Looks good to me |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
…ors API (#330) * onboard search connectors api; add auto-fetching of dimensions Signed-off-by: Tyler Ohlsen <[email protected]> * Reset to undefined if no values found Signed-off-by: Tyler Ohlsen <[email protected]> * add comment Signed-off-by: Tyler Ohlsen <[email protected]> * minor tuning of select autofill in maps Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 8461369)
ohltyler
added a commit
that referenced
this pull request
Aug 30, 2024
…ors API (#330) (#335) * onboard search connectors api; add auto-fetching of dimensions Signed-off-by: Tyler Ohlsen <[email protected]> * Reset to undefined if no values found Signed-off-by: Tyler Ohlsen <[email protected]> * add comment Signed-off-by: Tyler Ohlsen <[email protected]> * minor tuning of select autofill in maps Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 8461369) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a set of constants for common embedding models from popular remote services. If a model name is found in the connector blueprint, and it is a model that we persist a constant for, we prefill the dimensions with the known value.
More details:
QuickConfigureInputsto try to derive thedimensionswhen a model is selected. this is done by traversing to the associated connector ID, extracting out the details, and looking for the model nameDemo video, showing the "Embedding length" field being auto-populated:
screen-capture.8.webm
Issues Resolved
N/A
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.