Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename visible plugin name to Search Studio #331

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ohltyler
Copy link
Member

Description

Renames all of the visible titles of the plugin on the UI, including the plugin name in the OSD side nav bar, the url paths, and the breadcrumbs. Also minor cleanup to add constants and some consistency.

Screenshots of changes:

side-nav

url

breadcrumbs

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler added documentation Improvements or additions to documentation infra Changes to infrastructure, testing, CI/CD, etc. backport 2.x labels Aug 30, 2024
@opensearch-trigger-bot opensearch-trigger-bot bot removed the documentation Improvements or additions to documentation label Aug 30, 2024
@amitgalitz
Copy link
Member

amitgalitz commented Aug 30, 2024

We are keeping github and build names the same still right? Should we mention in development guide so people know dashboards-flow-framework is search studio or just keep as is?

@ohltyler
Copy link
Member Author

We are keeping github and build names the same still right? Should we mention in development guide so people know dashboards-flow-framework is search studio or just keep as is?

I'll have a followup PR to update some basic info in the developer guide. For now we are leaving everything else as-is until the naming is completely finalized, in which case we may change things more. Also depends on if we will release experimental in 2.17.

@ohltyler ohltyler merged commit 7284560 into opensearch-project:main Aug 30, 2024
10 checks passed
@ohltyler ohltyler deleted the plugin-rename branch August 30, 2024 16:34
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 7284560)
ohltyler added a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 7284560)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x infra Changes to infrastructure, testing, CI/CD, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants