Refactor & improve Workflow Builder; connect to redux store #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
ohltyler
force-pushed
the
builder-improvements
branch
from
db360ff
to
e9db5fd
Compare
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
force-pushed
the
builder-improvements
branch
from
e9db5fd
to
6b51c8f
Compare
Signed-off-by: Tyler Ohlsen <[email protected]>
dbwiddis
approved these changes
Sep 25, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit ea04bce)
ohltyler
added a commit
that referenced
this pull request
Sep 25, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit ea04bce) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR accomplishes a few things:
EuiInMemoryTableand fetching from redux storeWorkspacecomponent to maintain workspace-related state. Fetches state (currently some default components) from redux storeThe switch to
EuiInMemoryTableis primarily because of the simplicity and less chance of bugs. If it is determined later on we will need dynamic fetching of data triggered by table change, and if storing all workflows in memory is too expensive, we can update then.Below is a demo showing the 2 hardcoded workflows rendered in the table. When clicking on them, it renders the details page with relevant info based on that workflow. Defaults to 2 hardcoded components in the workspace.
screen-capture.17.webm
Issues Resolved
Makes progress on #8, #10, #13
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.