Expanded unit test coverage for key UI components #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <[email protected]>
saimedhi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
ohltyler
reviewed
Sep 20, 2024
There was a problem hiding this comment.
LGTM, just one minor comment. Also, let's not close #95, that is supposed to cover full UT coverage for the plugin, and I'd estimate we are maybe 10/15% there. Since so far, this is just basic checks on the high-level base pages. But I think it's a good spot for now, since UX is still uncertain for the lower-level components for now. Could you help update / add to that meta issue with sub-issues to cover the rest of the UT coverage? Such as:
- components under
tools/ - components under
workflow_inputs/(the largest remaining effort) - components under
workspace/ - all of the util fns (particularly the ones under
public/utils/) (probably the second-largest remaining effort) codecovtest coverage integration like we have in the AD plugin
Signed-off-by: saimedhi <[email protected]>
ohltyler
approved these changes
Sep 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Expanded test coverage for key UI components Signed-off-by: saimedhi <[email protected]> * Expanded test coverage for key UI components Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]> (cherry picked from commit 95049f7)
ohltyler
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Expanded test coverage for key UI components Signed-off-by: saimedhi <[email protected]> * Expanded test coverage for key UI components Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]> (cherry picked from commit 95049f7) Co-authored-by: Sai Medhini Reddy Maryada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
related to #95
closes #98
closes #100
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.