Add empty source input checks (ingest & search) #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
added
enhancement
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
saimedhi
approved these changes
Sep 20, 2024
|
Looks good to me. |
|
Seeing a test failure. will rerun tests. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Add empty source input checks; remove legacy files Signed-off-by: Tyler Ohlsen <[email protected]> * repeat for output transform Signed-off-by: Tyler Ohlsen <[email protected]> * add disabled check Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit dd20c6f)
saimedhi
pushed a commit
that referenced
this pull request
Sep 20, 2024
* Add empty source input checks; remove legacy files Signed-off-by: Tyler Ohlsen <[email protected]> * repeat for output transform Signed-off-by: Tyler Ohlsen <[email protected]> * add disabled check Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit dd20c6f) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds checks to prevent invalid running of the fetching of source input data or source output data, which can be expensive under certain scenarios (e.g., running ML inference). Adds informational callout and disables the buttons when conditions are met. Screenshots below.
Also adds few missed cases of wrapping JSON.parse() calls in try/catch, when the inputs could potentially be in bad formats and cause uncaught exceptions.
Also removes few legacy empty files.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.