Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL update for 'Create workflow' button (list page) #416

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Oct 9, 2024

Description

The active tab update does not occur when clicking the "create workflow" button from the list page. This fixes that.

Also fixes the backport args reqd with the new version of the backport action in the workflow.

Issues Resolved

Resolves #414
Resolves #415

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing Tyler.

@saimedhi saimedhi merged commit afcdcce into opensearch-project:main Oct 9, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 9, 2024
* add replace tab logic

Signed-off-by: Tyler Ohlsen <[email protected]>

* fix backport args

Signed-off-by: Tyler Ohlsen <[email protected]>

---------

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit afcdcce)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ohltyler ohltyler deleted the create-workflow-bug branch October 9, 2024 18:42
ohltyler pushed a commit that referenced this pull request Oct 9, 2024
* add replace tab logic



* fix backport args



---------


(cherry picked from commit afcdcce)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working
Projects
None yet
2 participants