Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fixes and minor UX improvements II #432

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Oct 18, 2024

Description

Continuation of #427 . Changes:

  • readonly views of the docs & query inputs are EuiCodeBlock
  • rename "Tools" to "Inspector"
  • remove workflow state in header of details page
  • make the right-side panel (the preview + tools panels) collapsible, instead of the workflow inputs, since workflow inputs is the primary space users will be interacting with
  • capitalize "PROCESSORS" when selecting a processor in ingest/search pipeline form inputs
  • cleans up some spacing issue due to Fit and Finish enhancements #428
  • moves edit import data into header
  • moves edit query / test query into header
  • tune wording & simplify layout of the input/output transform form components (MapArrayField / MapField)

Demo video highlighting changes:

screen-capture.11.webm

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added bug Something isn't working enhancement New feature or request backport 2.x labels Oct 18, 2024
@ohltyler ohltyler marked this pull request as draft October 18, 2024 19:12
@ohltyler ohltyler marked this pull request as ready for review October 18, 2024 23:20
Copy link
Collaborator

@saimedhi saimedhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ohltyler ,

  • Looks good to me.
  • Could you please merge integration test workflow. So, that integration tests start running on PRs.Added Integration Tests Workflow #426
  • With the changes in this PR, I'll make the necessary updates to the integration test specs in the Functional Test repo. Thank you!

@ohltyler
Copy link
Member Author

With the changes in this PR, I'll make the necessary updates to the integration test specs in the Functional Test repo. Thank you!

@saimedhi can you help update the tests? The button functionality has changed from #427

@kamingleung
Copy link

@ohltyler Thanks for your updates!
Small nit: Can the Edit + Run query buttons be floating and align to the right? It looks like there may be extra spacing in between the buttons
image

@ohltyler
Copy link
Member Author

@kamingleung I've remove spacing entirely and kept it aligned to the right. The little bit of remaining visible "spacing" is due to the empty button itself. Lmk if concerns or if I should override the button widths to get them even closer.

Screenshot 2024-10-22 at 8 10 00 AM

@saimedhi
Copy link
Collaborator

@ohltyler , I am okay merging this PR. I am fixing integ tests.

@saimedhi
Copy link
Collaborator

Integ tests passing.

@saimedhi saimedhi merged commit f3d665c into opensearch-project:main Oct 23, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
* Change readonly fields into codeblock

Signed-off-by: Tyler Ohlsen <[email protected]>

* Change which panel is collapsible; various wording changes

Signed-off-by: Tyler Ohlsen <[email protected]>

* Move edit buttons of ingest/search in header; spacing cleanup

Signed-off-by: Tyler Ohlsen <[email protected]>

* Update wording and layout of input/output transform form components

Signed-off-by: Tyler Ohlsen <[email protected]>

* update tests

Signed-off-by: Tyler Ohlsen <[email protected]>

* remove gutter entirely on query buttons

Signed-off-by: Tyler Ohlsen <[email protected]>

---------

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit f3d665c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-432-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f3d665c2a30c08292e6477ae7edbbdc1bd865004
# Push it to GitHub
git push --set-upstream origin backport/backport-432-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-432-to-2.x.

ohltyler added a commit to ohltyler/dashboards-flow-framework that referenced this pull request Oct 29, 2024
* Change readonly fields into codeblock

Signed-off-by: Tyler Ohlsen <[email protected]>

* Change which panel is collapsible; various wording changes

Signed-off-by: Tyler Ohlsen <[email protected]>

* Move edit buttons of ingest/search in header; spacing cleanup

Signed-off-by: Tyler Ohlsen <[email protected]>

* Update wording and layout of input/output transform form components

Signed-off-by: Tyler Ohlsen <[email protected]>

* update tests

Signed-off-by: Tyler Ohlsen <[email protected]>

* remove gutter entirely on query buttons

Signed-off-by: Tyler Ohlsen <[email protected]>

---------

Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi pushed a commit that referenced this pull request Oct 29, 2024
* Change readonly fields into codeblock



* Change which panel is collapsible; various wording changes



* Move edit buttons of ingest/search in header; spacing cleanup



* Update wording and layout of input/output transform form components



* update tests



* remove gutter entirely on query buttons



---------

Signed-off-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x bug Something isn't working enhancement New feature or request failed backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants