-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc bug fixes and minor UX improvements II #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Looks good to me.
- Could you please merge integration test workflow. So, that integration tests start running on PRs.Added Integration Tests Workflow #426
- With the changes in this PR, I'll make the necessary updates to the integration test specs in the Functional Test repo. Thank you!
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler Thanks for your updates! |
Signed-off-by: Tyler Ohlsen <[email protected]>
@kamingleung I've remove spacing entirely and kept it aligned to the right. The little bit of remaining visible "spacing" is due to the empty button itself. Lmk if concerns or if I should override the button widths to get them even closer. |
@ohltyler , I am okay merging this PR. I am fixing integ tests. |
Integ tests passing. |
* Change readonly fields into codeblock Signed-off-by: Tyler Ohlsen <[email protected]> * Change which panel is collapsible; various wording changes Signed-off-by: Tyler Ohlsen <[email protected]> * Move edit buttons of ingest/search in header; spacing cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * Update wording and layout of input/output transform form components Signed-off-by: Tyler Ohlsen <[email protected]> * update tests Signed-off-by: Tyler Ohlsen <[email protected]> * remove gutter entirely on query buttons Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit f3d665c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-432-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f3d665c2a30c08292e6477ae7edbbdc1bd865004
# Push it to GitHub
git push --set-upstream origin backport/backport-432-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-flow-framework/backport-2.x Then, create a pull request where the |
* Change readonly fields into codeblock Signed-off-by: Tyler Ohlsen <[email protected]> * Change which panel is collapsible; various wording changes Signed-off-by: Tyler Ohlsen <[email protected]> * Move edit buttons of ingest/search in header; spacing cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * Update wording and layout of input/output transform form components Signed-off-by: Tyler Ohlsen <[email protected]> * update tests Signed-off-by: Tyler Ohlsen <[email protected]> * remove gutter entirely on query buttons Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]>
* Change readonly fields into codeblock * Change which panel is collapsible; various wording changes * Move edit buttons of ingest/search in header; spacing cleanup * Update wording and layout of input/output transform form components * update tests * remove gutter entirely on query buttons --------- Signed-off-by: Tyler Ohlsen <[email protected]>
Description
Continuation of #427 . Changes:
EuiCodeBlock
Demo video highlighting changes:
screen-capture.11.webm
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.