Add interfaces & types; fetch reactflow state from workflow redux store #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
dbwiddis
approved these changes
Oct 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
…re (#45) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit d9e697c)
ohltyler
added a commit
that referenced
this pull request
Oct 2, 2023
…re (#45) (#46) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit d9e697c) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR accomplishes 2 main things:
Workflowplugin resource and all that it is comprised of. Note that types are preferred over interfaces, and we are only using interfaces for their ease of use of both 1/ extending them to child interfaces, and 2/ implementing them via Classes.reactFlowStatefield of aWorkflow, which is where it will persist after fetching this from the backend later on. Populates the nodes/edges in theWorkspaceby pulling this from theworkflowprop when rendering the component.Other:
eslintrc.jsonfile & updated yarn script such that we ignore a few rules altogether that are unnecessary. This way, we don't have to continuously add// eslint-disable-next-line <rule>for things like empty interfaces that we may fill in later, etc.Testing:
Issues Resolved
Closes #12 . Makes progress on #8 , #10
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.