Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the SideNav within the flow framework dashboards #451

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Removing the SideNav within the flow framework dashboards #451

merged 1 commit into from
Oct 30, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Oct 30, 2024 •
edited
Loading

Description

OldHomePage:

Screenshot 2024-10-30 at 12 10 33 PM Screenshot 2024-10-30 at 12 10 45 PM

NewHomePage:

Screenshot 2024-10-30 at 12 11 36 PM Screenshot 2024-10-30 at 12 11 51 PM

Issues Resolved

closes #444

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi saimedhi marked this pull request as ready for review October 30, 2024 19:17
ohltyler
ohltyler approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saimedhi saimedhi merged commit 4ee340f into opensearch-project:main Oct 30, 2024
12 of 13 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
@github-actions
Removing the SideNav within the flow framework dashboards (#451)
f4a9cf5 
Signed-off-by: saimedhi <[email protected]>
(cherry picked from commit 4ee340f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 30, 2024
Merged
saimedhi pushed a commit that referenced this pull request Oct 30, 2024
@opensearch-trigger-bot @github-actions
Removing the SideNav within the flow framework dashboards (#451) (#453)
a64af7a 
(cherry picked from commit 4ee340f)

Signed-off-by: saimedhi <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohltyler ohltyler ohltyler approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@minalsha minalsha Awaiting requested review from minalsha minalsha is a code owner

Assignees
No one assigned
Labels
backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Proposing removal of Side Nav present in the dashboards flow framework plugin
2 participants
@saimedhi @ohltyler