Onboard custom node type to Workspace #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
dbwiddis
approved these changes
Oct 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit bc60dc0)
ohltyler
added a commit
that referenced
this pull request
Oct 2, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit bc60dc0) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the custom node type which references the
WorkspaceComponent. This is the single custom node type we will use to render all of the different types (e.g., text embedding processor, knn index, etc.). Short demo of those components in the ReactFlow workspace shown below.Also does minor comment cleanup and removes the
init()fn for now. We will likely need some helper fns for these classes later on, but removing what's not needed for now.screen-capture.11.webm
Issues Resolved
Makes progress on #10, #16
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.