Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental badging I; update plugin name #472

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Nov 8, 2024

Description

Phase 1 of adding experimental badging. Adds the experimental badge in 2 locations:

  1. Overview page (new UI)
  2. Workflows page (old UI)

The badge, when clicked, opens a popover with details + button link to provide feedback on GitHub.

Other changes:

  • plugin name changes to "OpenSearch Flow"
  • refactors / updates / cleans up search_studio_card to opensearch_flow_card
  • changes name of SHOW_ACTIONS_IN_HEADER to USE_NEW_HOME_PAGE for clarity

Demo video showing the 2 places the badge has been added:

screen-capture.1.webm

Issues Resolved

Makes progress on #461

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler marked this pull request as ready for review November 8, 2024 23:49
@ohltyler ohltyler changed the title Add experimental badging I Add experimental badging I; update plugin name Nov 8, 2024
@ohltyler ohltyler merged commit 8583568 into opensearch-project:main Nov 11, 2024
6 of 7 checks passed
@ohltyler ohltyler deleted the experimental branch November 11, 2024 18:35
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 11, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 8583568)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Nov 11, 2024
(cherry picked from commit 8583568)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants