Improve consistency of JSONPath parsing & execution across frontend/backend #481
+149
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
5 tasks
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
reviewed
Nov 15, 2024
public/utils/utils.ts
Outdated
| jsonpath.query(input, path) | ||
| : // Standard dot notation | ||
| get(input, path); | ||
| // Rregular dot notation can only be executed if 1/ the JSONPath selector is not explicitly defined, |
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
approved these changes
Nov 15, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
…ackend (#481) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 75ae094) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Nov 15, 2024
…ackend (#481) (#482) (cherry picked from commit 75ae094) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the path parsing and JSONPath handling when configuring advanced transforms in the ML processors. Added detailed comments in the source code for readability.
generateTransformto handle more edge cases and be consistent without the backend handles path parsing for the different scenarios (input vs. output, ingest vs. search request vs. search response).sanitizeJSONPath()fn used in 2 places: 1/ when auto-populating keys for the query or document JSONs (ensures they will run consistently on frontend & backend), and 2/ when converting to a template (to ensure it runs properly on the backend).isIndefiniteJsonPath()to help make the return values of a JSONPath execution consistent. Note: this is not a full-featured fn. The frontend libraries do not have any configuration similar toALWAYS_RETURN_LIST, nor a mechanism to determine whether a path is definite or indefinite. The purpose of this function is to broadly cover the majority of use cases to mimic the implementation as close as possible.More details on the fixes this covers in the related issue #478 .
Issues Resolved
Resolves #478
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.