Add multi-filtering to tables; refactor details pages into tabs #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
ohltyler
changed the title
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
commented
Oct 23, 2023
| return; | ||
| } | ||
| const newFilters = [...filters]; | ||
| // @ts-ignore |
There was a problem hiding this comment.
TLDR of adding all of these ignores is due to IDE complaints that the type fields don't match. This is due to differences in EUI vs. OUI and their respective documentation. This follows the latest OUI documentation.
ohltyler
commented
Oct 23, 2023
| interface MultiSelectFilterProps { | ||
| title: string; | ||
| filters: EuiFilterSelectItem[]; | ||
| setSelectedFilters: (filters: EuiFilterSelectItem[]) => void; |
There was a problem hiding this comment.
We have this setter as a prop since typically any filter changes will need to be propagated to the parent component(s).
ohltyler
commented
Oct 23, 2023
| @@ -11,6 +11,7 @@ import { saveWorkflow } from '../utils'; | |||
| import { rfContext, AppState, removeDirty } from '../../../store'; | |||
|
|
|||
| interface WorkflowDetailHeaderProps { | |||
| tabs: any[]; | |||
There was a problem hiding this comment.
Tab isn't exposed by EUI/OUI library so we set as any.
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
changed the title
amitgalitz
approved these changes
Feb 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 26, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit edcd453)
ohltyler
added a commit
that referenced
this pull request
Feb 26, 2024
…#83) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit edcd453) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves 4 main things:
MultiSelectFiltercomponent that can be added to tables for filtering by subset of available options (e.g., workflow status).With the refactoring, this also does some minor styling & padding changes for consistency, and adds boilerplate pages for the unfinished Launches and Prototypes pages under their respective tabs
Demo video (table enhancements):
screen-capture.21.webm
Demo video (new workflow details tabs):
screen-capture.22.webm
Issues Resolved
Makes progress on #8, #13, #15
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.