Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workflow list] Add delete modal; add empty list msg #93

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[Workflow list] Add delete modal; add empty list msg #93

merged 1 commit into from
Mar 1, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Mar 1, 2024 •
edited
Loading

Description

This PR improves the Workflow List page and makes consistent with the mocks in a few ways:

  • adds a confirmation model before workflow deletion. This will be expanded upon in the future to list out associated resources, optionally deprovision, show for all versions, etc. Making a standalone component so it can be shared across pages if needed (e.g., deleting within the details pages)
  • enhances the empty list message to include an actionable button that navigates to the 'create workflow' tab

Demo:
video.webm

Issues Resolved

Resolves #92

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

joshpalis
joshpalis approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@joshpalis joshpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ohltyler ohltyler merged commit 454ee82 into opensearch-project:main Mar 1, 2024
7 of 8 checks passed
@ohltyler ohltyler deleted the improve-delete branch March 1, 2024 16:30
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 1, 2024
@ohltyler @github-actions
Add delete modal; add empty list msg (#93)
3e1db0d 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 454ee82)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 1, 2024
Merged
ohltyler added a commit that referenced this pull request Mar 1, 2024
@opensearch-trigger-bot @ohltyler
Add delete modal; add empty list msg (#93) (#94)
9b7024b 
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 454ee82)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshpalis joshpalis joshpalis approved these changes

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

Assignees
No one assigned
Labels
backport 2.x rapid workflow list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Workflow list] Improve delete flow
2 participants
@ohltyler @joshpalis