change order of validation and add try catch in semver check (#297)

Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 71411b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-project · Oct 30, 2024 · 3f2256c · 3f2256c
1 parent 84cef98
commit 3f2256c
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/public/pages/Main/Main.tsx b/public/pages/Main/Main.tsx
@@ -177,12 +177,22 @@ export default class Main extends Component<MainProps, MainState> {
   };
 
   dataSourceFilterFn = (dataSource: SavedObject<DataSourceAttributes>) => {
-    const dataSourceVersion = dataSource?.attributes?.dataSourceVersion || "";
-    const installedPlugins = dataSource?.attributes?.installedPlugins || [];
-    return (
-      semver.satisfies(dataSourceVersion, pluginManifest.supportedOSDataSourceVersions) &&
-      pluginManifest.requiredOSDataSourcePlugins.every((plugin) => installedPlugins.includes(plugin))
-    );
+    try {
+      const dataSourceVersion = dataSource?.attributes?.dataSourceVersion || '';
+      const installedPlugins = dataSource?.attributes?.installedPlugins || [];
+      return (
+        pluginManifest.requiredOSDataSourcePlugins.every((plugin) =>
+          installedPlugins.includes(plugin)
+        ) &&
+        semver.satisfies(
+          dataSourceVersion,
+          pluginManifest.supportedOSDataSourceVersions
+        )
+      );
+    } catch (error) {
+      // Filter out invalid data source
+      return false;
+    }
   };
 
   getServices(http: HttpSetup) {