Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually backport #44, support Microsoft Teams config type #103

Merged

Conversation

zhichao-aws
Copy link
Member

Description

The backport for #44 failed. Create a backport mannually.
The failure reason is 2 UT from commit 8d514d4 doesn't exist in 2.x, while our PR modify those 2 UT. To keep consistent with previous settings, I remove these modifications in these 2 UT.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zhichao-aws <[email protected]>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #103 (165cd0d) into 2.x (9ce3fbb) will increase coverage by 0.16%.
Report is 8 commits behind head on 2.x.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #103      +/-   ##
==========================================
+ Coverage   86.40%   86.57%   +0.16%     
==========================================
  Files          51       52       +1     
  Lines        1479     1497      +18     
  Branches      352      373      +21     
==========================================
+ Hits         1278     1296      +18     
  Misses        198      198              
  Partials        3        3              
Flag Coverage Δ
dashboards-notifications 86.57% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@zhichao-aws zhichao-aws changed the title cherry-pick 5903c2737042f8854db86634c288033223dd07f8 Manually backport #44, support Microsoft Teams config type Aug 29, 2023
@zhichao-aws zhichao-aws added the v2.10.0 Issues targeting release v2.10.0 label Aug 29, 2023
@zhichao-aws zhichao-aws merged commit c083061 into opensearch-project:2.x Aug 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants