Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Replaced wrongly formatted mock Slack URLs with properly formatted mock Slack URLs #143

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7aba242 from #139.

…ck Slack URLs (#139)

* Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <[email protected]>

* Update snapshot of unit tests

Ran `yar test:jest -u`

Signed-off-by: Aniruddh <[email protected]>

---------

Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
(cherry picked from commit 7aba242)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (905c6ed) 86.57% compared to head (b83f75c) 86.57%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x     #143   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files          52       52           
  Lines        1497     1497           
  Branches      360      360           
=======================================
  Hits         1296     1296           
  Misses        198      198           
  Partials        3        3           
Flag Coverage Δ
dashboards-notifications 86.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhichao-aws zhichao-aws merged commit c2b77b6 into 2.x Nov 30, 2023
15 checks passed
@github-actions github-actions bot deleted the backport/backport-139-to-2.x branch November 30, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants