Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix: CI flow on windows main (#145) #147

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Nov 29, 2023

  • feat: remove useless step

Signed-off-by: SuZhou-Joe [email protected]

  • feat: add opensearch logs

Signed-off-by: SuZhou-Joe [email protected]

  • feat: update

Signed-off-by: SuZhou-Joe [email protected]

  • feat: add more requestTimeout

Signed-off-by: SuZhou-Joe [email protected]


Signed-off-by: SuZhou-Joe [email protected]
Co-authored-by: Hailong Cui [email protected]
(cherry picked from commit 15c0b72)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* feat: remove useless step

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add opensearch logs

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add more requestTimeout

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Hailong Cui <[email protected]>
(cherry picked from commit 15c0b72)
Signed-off-by: SuZhou-Joe <[email protected]>
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (905c6ed) 86.57% compared to head (d599902) 86.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x     #147   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files          52       52           
  Lines        1497     1497           
  Branches      360      360           
=======================================
  Hits         1296     1296           
  Misses        198      198           
  Partials        3        3           
Flag Coverage Δ
dashboards-notifications 86.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe changed the title Fix: CI flow on windows main (#145) [Backport 2.x]Fix: CI flow on windows main (#145) Nov 30, 2023
@SuZhou-Joe SuZhou-Joe changed the title [Backport 2.x]Fix: CI flow on windows main (#145) [Backport 2.x] Fix: CI flow on windows main (#145) Nov 30, 2023
Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@yuye-aws yuye-aws merged commit 4e241e1 into opensearch-project:2.x Nov 30, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants