Feat: remove opensearch.log introduced from #145 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90 and
praveensameneni
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 52 52
Lines 1497 1497
Branches 360 360
=======================================
Hits 1298 1298
Misses 196 196
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xluo-aws
approved these changes
Nov 30, 2023
Hailong-am
approved these changes
Nov 30, 2023
SuZhou-Joe
changed the title
SuZhou-Joe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Windows, there is a file lock which makes action/upload-artifact unable to upload opensearch.log.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.