update snapshot #168
Merged
update snapshot #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
xluo-aws,
gaobinlong,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni and
amsiglan
as code owners
Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe
reviewed
Mar 15, 2024
| @@ -26,7 +26,7 @@ | |||
| "@types/showdown": "^1.9.3", | |||
| "enzyme-adapter-react-16": "^1.15.5", | |||
| "jest-dom": "^4.0.0", | |||
| "cypress": "^6.0.0" | |||
| "cypress": "9.5.4" | |||
There was a problem hiding this comment.
come from here https://github.com/opensearch-project/dashboards-notifications/actions/runs/8290160637/job/22687774853
Either we add --single-version=loose/ignore in the CI or upgrade to same version will resolve the CI failure.
As ftr repo using the cypress 9.5.4, so i decide to upgrade to same version to avoid any potential version issue when copy the test to ftr repo and fix the version conflict here.
ERROR [single_version_dependencies] Multiple version ranges for the same dependency
were found declared across different package.json files. Please consolidate
those to match across all package.json files. Different versions for the
same dependency is not supported.
If you have questions about this please reach out to the operations team.
The conflicting dependencies are:
cypress
9.5.4 => opensearch-dashboards
^6.0.0 => notifications-dashboards
There was a problem hiding this comment.
I see, thanks for the clarification.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 52 52
Lines 1497 1497
Branches 360 373 +13
=======================================
Hits 1298 1298
Misses 196 196
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Mar 15, 2024
zhichao-aws
approved these changes
Mar 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
* update snapshot Signed-off-by: Hailong Cui <[email protected]> * upgrade cypress to 9.5.4 Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 16f494e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Mar 15, 2024
* update snapshot * upgrade cypress to 9.5.4 --------- (cherry picked from commit 16f494e) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update obsolete snapshot due to OUI upgrade
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.