[Backport 2.17] Fit and Finish UX Fixes #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fill send test message button Signed-off-by: Joanne Wang <[email protected]> * extend content to full width of page Signed-off-by: Joanne Wang <[email protected]> * fix spacing across buttons (8px) Signed-off-by: Joanne Wang <[email protected]> * add vertical spacing Signed-off-by: Joanne Wang <[email protected]> * fix header and content 16px Signed-off-by: Joanne Wang <[email protected]> * remove extra 10px padding Signed-off-by: Joanne Wang <[email protected]> * align active indicator Signed-off-by: Joanne Wang <[email protected]> * wrap h2 in Eui Title with size s prop Signed-off-by: Joanne Wang <[email protected]> * fix padding for elements from search bar 8px Signed-off-by: Joanne Wang <[email protected]> * remove bottom border in empty state Signed-off-by: Joanne Wang <[email protected]> * wip Signed-off-by: Joanne Wang <[email protected]> * fix original view monitors page Signed-off-by: Joanne Wang <[email protected]> * fix original spacing Signed-off-by: Joanne Wang <[email protected]> * run yarn test:jest -u Signed-off-by: Joanne Wang <[email protected]> * upgrade to v4 Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]> (cherry picked from commit 7dd95ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan,
AWSHurneyt and
riysaxen-amzn
as code owners
AWSHurneyt
approved these changes
Sep 17, 2024
amsiglan
approved these changes
Sep 17, 2024
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
…project#269)" This reverts commit b3dd31c.
1 task
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
…project#269)" This reverts commit b3dd31c. Signed-off-by: Joanne Wang <[email protected]>
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Revert "[Backport 2.17] Fit and Finish UX Fixes Pt 2. (#275)" This reverts commit 5ac0919. Signed-off-by: Joanne Wang <[email protected]> * Revert "Fit and Finish UX Fixes (#263) (#269)" This reverts commit b3dd31c. Signed-off-by: Joanne Wang <[email protected]> * Revert "Use TopNavControlButtonData for channel test button (#243) (#268)" This reverts commit 127eae4. Signed-off-by: Joanne Wang <[email protected]> * Revert "[Fit & Finish] Updated Fit and Finish guidelines (#256) (#259)" This reverts commit fb48dbc. Signed-off-by: Joanne Wang <[email protected]> --------- Signed-off-by: Joanne Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 7dd95ec from #263.