Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit and Finish UX Fixes Pt 2. #270

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

jowg-amazon
Copy link
Contributor

Description

Last changes for the fit and finish UX fixes. The changes in this PR include:

  • Separating the table filters
  • Adding a default pill to the encryption method dropdown

Screenshot 2024-09-18 at 1 14 38 PM

Screenshot 2024-09-18 at 1 14 25 PM

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AWSHurneyt AWSHurneyt merged commit 13d80a5 into opensearch-project:main Sep 18, 2024
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
* add default pill to encryption method

Signed-off-by: Joanne Wang <[email protected]>

* make table filters separate

Signed-off-by: Joanne Wang <[email protected]>

* run yarn test:jest-u

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 13d80a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
* add default pill to encryption method

Signed-off-by: Joanne Wang <[email protected]>

* make table filters separate

Signed-off-by: Joanne Wang <[email protected]>

* run yarn test:jest-u

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 13d80a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Sep 19, 2024
* add default pill to encryption method



* make table filters separate



* run yarn test:jest-u



---------


(cherry picked from commit 13d80a5)

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this pull request Sep 20, 2024
* Fit and Finish UX Fixes Pt 2. (#270)

* add default pill to encryption method

Signed-off-by: Joanne Wang <[email protected]>

* make table filters separate

Signed-off-by: Joanne Wang <[email protected]>

* run yarn test:jest-u

Signed-off-by: Joanne Wang <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
(cherry picked from commit 13d80a5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update dashboards-notifications-test-and-build-workflow.yml

Signed-off-by: AWSHurneyt <[email protected]>

* Update dashboards-notifications-test-and-build-workflow-prod-docker-linux.yml

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Joanne Wang <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants