Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache cypress hashfile path #280

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jowg-amazon
Copy link
Contributor

Description

CI is failing on Cache Cypress step.

Error: The template is not valid. .github/workflows/dashboards-notifications-test-and-build-workflow.yml (Line: 173, Col: 16): hashFiles('**/package.json') couldn't finish within 120 seconds.

This PR adjusts the name of the hashfile so it's consistent with main

OpenSearch-Dashboards/plugins/dashboards-notifications/package.json

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joanne Wang <[email protected]>
@jowg-amazon jowg-amazon changed the title Fix cache cypress for 2.x Fix cache cypress hashfile path Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (2649dfa) to head (d8ddb5a).
Report is 9 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x     #280      +/-   ##
==========================================
- Coverage   82.63%   82.33%   -0.30%     
==========================================
  Files          55       55              
  Lines        1687     1721      +34     
  Branches      456      462       +6     
==========================================
+ Hits         1394     1417      +23     
- Misses        286      297      +11     
  Partials        7        7              
Flag Coverage Δ
dashboards-notifications 82.33% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AWSHurneyt AWSHurneyt merged commit 0182303 into opensearch-project:2.x Sep 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants