Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E wait for dashboards-server Green status #1048

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pjfitzgibbons
Copy link
Contributor

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ca2c75) 53.87% compared to head (4287308) 53.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1048   +/-   ##
=======================================
  Coverage   53.87%   53.87%           
=======================================
  Files         316      316           
  Lines       11309    11309           
  Branches     2957     3014   +57     
=======================================
  Hits         6093     6093           
+ Misses       5168     5167    -1     
- Partials       48       49    +1     
Flag Coverage Δ
dashboards-observability 53.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pjfitzgibbons pushed a commit that referenced this pull request Oct 5, 2023
* first

Signed-off-by: Abhay Pandey <[email protected]>

* number of gauge

Signed-off-by: Abhay Pandey <[email protected]>

* changes after rebase

Signed-off-by: Abhay Pandey <[email protected]>

* rebase

Signed-off-by: Abhay Pandey <[email protected]>

* number of gauges fixed in this commit

Signed-off-by: Abhay Pandey <[email protected]>

* removed the duplicate constant

Signed-off-by: Abhay Pandey <[email protected]>

Signed-off-by: Abhay Pandey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants