Fix no matching issue corner case for lint CI #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric <[email protected]>
mengweieric
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
RyanL1997
approved these changes
Dec 20, 2023
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
- Coverage 57.42% 51.55% -5.87%
==========================================
Files 330 305 -25
Lines 12091 10652 -1439
Branches 2792 2794 +2
==========================================
- Hits 6943 5492 -1451
- Misses 5102 5114 +12
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ps48
approved these changes
Dec 20, 2023
Signed-off-by: Eric <[email protected]>
RyanL1997
reviewed
Dec 20, 2023
| '@typescript-eslint/no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| argsIgnorePattern: '^_', |
pjfitzgibbons
approved these changes
Dec 20, 2023
6 tasks
joshuali925
reviewed
Dec 21, 2023
Signed-off-by: Eric <[email protected]>
RyanL1997
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Hi @mengweieric , thanks for this enhancement. I was working with @joshuali925 for the following comments.
mengweieric
force-pushed
the
fix/no-matching
branch
from
532df66
to
febe215
Compare
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Dec 22, 2023
* no matching corner case Signed-off-by: Eric <[email protected]> * adjust some linting rules Signed-off-by: Eric <[email protected]> * using bash array Signed-off-by: Eric <[email protected]> * improve linter Signed-off-by: Eric <[email protected]> * remove redundant check Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]>
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Dec 22, 2023
* no matching corner case Signed-off-by: Eric <[email protected]> * adjust some linting rules Signed-off-by: Eric <[email protected]> * using bash array Signed-off-by: Eric <[email protected]> * improve linter Signed-off-by: Eric <[email protected]> * remove redundant check Signed-off-by: Eric <[email protected]> --------- Signed-off-by: Eric <[email protected]>
6 tasks
mengweieric
added a commit
that referenced
this pull request
Jan 3, 2024
* no matching corner case * adjust some linting rules * using bash array * improve linter * remove redundant check --------- Signed-off-by: Eric <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
… (opensearch-project#1326) * no matching corner case * adjust some linting rules * using bash array * improve linter * remove redundant check --------- Signed-off-by: Eric <[email protected]> (cherry picked from commit 9c15db0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
succeeded on no matched file: https://github.com/opensearch-project/dashboards-observability/actions/runs/7281188230/job/19841193026#step:8:3
fails on having lint error: https://github.com/mengweieric/dashboards-observability/actions/runs/7281399534/job/19841832379
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.