Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Backporting #1409 Panels Tests Updates #1441

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

sejli
Copy link
Member

@sejli sejli commented Feb 14, 2024

Description

Issues Resolved

#201 #1278

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ds and Fixing Cypress Tests (opensearch-project#1409)

* improving test coverage on panels and fixing flaky cypress tests

Signed-off-by: Sean Li <[email protected]>

* updating snapshot

Signed-off-by: Sean Li <[email protected]>

* mocking time so snapshots are consistent

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 1211e83)
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3afae5c) 55.01% compared to head (0402b04) 56.85%.

Files Patch % Lines
...lic/components/custom_panels/custom_panel_view.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1441      +/-   ##
==========================================
+ Coverage   55.01%   56.85%   +1.83%     
==========================================
  Files         315      318       +3     
  Lines       11182    11524     +342     
  Branches     2933     3005      +72     
==========================================
+ Hits         6152     6552     +400     
+ Misses       4980     4920      -60     
- Partials       50       52       +2     
Flag Coverage Δ
dashboards-observability 56.85% <33.33%> (+1.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulstn paulstn merged commit 8b7966b into opensearch-project:2.x Feb 14, 2024
14 of 23 checks passed
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…es (opensearch-project#1441)

* [MAINTENANCE] Improving Jest Test Coverage for Observability Dashboards and Fixing Cypress Tests  (opensearch-project#1409)

* improving test coverage on panels and fixing flaky cypress tests

Signed-off-by: Sean Li <[email protected]>

* updating snapshot

Signed-off-by: Sean Li <[email protected]>

* mocking time so snapshots are consistent

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 1211e83)

* cherry picking 3b179c5 and removing fetchAggregatedBins() test

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 8b7966b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants