-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/CD] Add single version flag during bootstrap to fix version conflicts and update the snapshots #1454
[CI/CD] Add single version flag during bootstrap to fix version conflicts and update the snapshots #1454
Conversation
Signed-off-by: Ryan Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Signed-off-by: Ryan Liang <[email protected]>
@mengweieric @ps48 Should we merge this one? Seems like the failure is irrelevant from the bootstrap issue. |
Just double check with @joshuali925 , and it seems like the build failure of snapshot is related to an upstream change. And we are trying to add the fix into this PR too. |
Signed-off-by: Joshua Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
+ Coverage 54.68% 56.55% +1.87%
==========================================
Files 317 320 +3
Lines 11373 11720 +347
Branches 3028 3042 +14
==========================================
+ Hits 6219 6628 +409
+ Misses 5103 5040 -63
- Partials 51 52 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1454-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e2d951fef1b639160ec10102496bd6c36349242
# Push it to GitHub
git push --set-upstream origin backport/backport-1454-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
Description
--single-version=loose
flag during the bootstrap step in our CI to manipulate the behavior of single-version validation.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.