Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose create acceleration flyout, update acceleration docs link #1513

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Mar 9, 2024

Description

  • Expose create acceleration flyout so dependent plugins can use it.
  • Update accelerations documentation link
  • Update onclick functions for the EUI cards in data connections tab

Issues Resolved

Follow-up on: #1508

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sejli
Copy link
Member

sejli commented Mar 9, 2024

Test and build failing because of issues with importing getRenderAccelerationFlyout from plugin.tsx. I think it's because running Jest tests doesn't start the plugin, which means the flyout doesn't get exported. I did a temporary fix for that in #1495 here.

Plugin.getRenderAccelerationDetailsFlyout = jest.fn();

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 47.05882% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 56.61%. Comparing base (ae629be) to head (97a8fc7).
Report is 2 commits behind head on main.

Files Patch % Lines
...manage/accelerations/selectors/source_selector.tsx 25.00% 6 Missing ⚠️
.../datasources/components/manage/data_connection.tsx 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   56.51%   56.61%   +0.10%     
==========================================
  Files         348      348              
  Lines       12655    12653       -2     
  Branches     3205     3202       -3     
==========================================
+ Hits         7152     7164      +12     
+ Misses       5449     5436      -13     
+ Partials       54       53       -1     
Flag Coverage Δ
dashboards-observability 56.61% <47.05%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 4fce74d into opensearch-project:main Mar 9, 2024
17 of 22 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 9, 2024
* expose create acceleration flyout, update docs link

Signed-off-by: Shenoy Pratik <[email protected]>

* update test for data_connection page

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 4fce74d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit that referenced this pull request Mar 9, 2024
…) (#1514)

* expose create acceleration flyout, update docs link



* update test for data_connection page



---------


(cherry picked from commit 4fce74d)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…nsearch-project#1513) (opensearch-project#1514)

* expose create acceleration flyout, update docs link

* update test for data_connection page

---------

(cherry picked from commit 4fce74d)

Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 83e972b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants